Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle excess objects correctly in FindObject #31

Open
jsha opened this issue Jul 22, 2020 · 0 comments
Open

Handle excess objects correctly in FindObject #31

jsha opened this issue Jul 22, 2020 · 0 comments

Comments

@jsha
Copy link
Contributor

jsha commented Jul 22, 2020

Currently, we are relying on a "more" boolean returned from
FindObjects. But according to
https://pkg.go.dev/github.com/miekg/pkcs11?tab=doc#Ctx.FindObjects,

The returned boolean value is deprecated and should be ignored.

Instead, we should ask for more objects than we need and error if we get
more than 1.

Related: letsencrypt/boulder#4972

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant