[HIDP-278] and [HIDP-279] Add password reset and rest confirmation routes #377
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fvanderpost
requested review from
153957,
bheesink,
bsimons,
dbunskoek,
ivanhulzen-leukeleu,
mkirkeng-leukeleu,
ramonakira and
wadevries
as code owners
github-actions
bot
added
documentation
bsimons
requested changes
Nov 10, 2025
Member
bsimons
left a comment
bsimons
left a comment
There was a problem hiding this comment.
We need configurable frontend URLs for the emails here as well.
And make sure we also send the Changed password mail
…to-request-a-reset-password
…to-request-a-reset-password
fvanderpost
force-pushed
the
hidp-278-as-i-user-i-want-to-be-able-to-request-a-reset-password
branch
from
b31c2eb to
ebfc780
Compare
fvanderpost
force-pushed
the
hidp-278-as-i-user-i-want-to-be-able-to-request-a-reset-password
branch
from
ebfc780 to
a059b32
Compare
fvanderpost
force-pushed
the
hidp-278-as-i-user-i-want-to-be-able-to-request-a-reset-password
branch
from
efae805 to
daf4e8a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should look into proper setup (if any) of sensitive variable decorators. Could implement a
viewsetwith actions but imo those belong more to model based operations.