-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Graph "scrubbing" is too agressive #45
Comments
The original |
Yeah. I'm adding it as an option to the playground per However, it's currently
db.jsonld.put('{"@context": "https://schema.org/", "name": "BigBlueHat"}', console.log.bind(console));
Regardless of the above (which I assume are bugs), I think setting |
Yes I think having preserve to true by default makes sense too. @mcollina Should we go all the way here? (i.e. change the default to preserve true) |
@BigBlueHat you might be interested in #46 as well |
Ok I've been able to reproduce the problem @BigBlueHat and since I can build the playground now I'll work on a fix. |
Well turns out there were several things at play here:
So if you do correct the options and use a "@context" object then things work as expected. I'll get to the fix now. |
New Playground with options settings is up! Consequently, you'll find some more interesting things... Basically, there's all kinds of crazy variations depending on where Right now, the playground is passing in Oh, and |
I'm working on a test for this (and understanding more about what changed), but here's the set of steps for playing with on the playground.
expect(triples).to.have.length(1)
is trueexpect(triples).to.have.length(2)
is false...there's only one. It replaced (maybe?) the original statement that had the ID. 😕expect(triples).to.have.length(2)
is true...um...OK...expect(triples).to.have.length(3)
is true...gah! WAT?! I'm back down to 1 😢Obviously...I'm missing something important here... 😀
@jmatsushita thoughts?
The text was updated successfully, but these errors were encountered: