Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

running-workflow-name does not work consistently #71

Open
egor-yolabs opened this issue Jul 13, 2022 · 1 comment
Open

running-workflow-name does not work consistently #71

egor-yolabs opened this issue Jul 13, 2022 · 1 comment

Comments

@egor-yolabs
Copy link

egor-yolabs commented Jul 13, 2022

From my testing over a couple of weeks, the functionality behind the "running-workflow-name" param is unreliable and will not always wait until all the other checks finish despite what the docs say. It does work most of the time, but there is a race condition. From my observation there is some period of time after a job finishes and another job (with a dependency on the first job) gets queued. If the "wait-on-check-action" just so happens to check the jobs status in that period of time, it will incorrectly conclude that all jobs have finished even though they haven't.

@ramseydsilva
Copy link

In my case, just using:

ref: ${{ github.ref }}
check-name: 'Run tests'

also leads to inconsistent results. Sometimes the check incorrectly assumes that the tasks have run. I have noticed that this happens when there are multiple jobs running, but possibly also happens otherwise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants