Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BSD license and GPL license missing from the binary package #94

Open
mwestphal opened this issue Nov 21, 2023 · 4 comments · Fixed by #84
Open

BSD license and GPL license missing from the binary package #94

mwestphal opened this issue Nov 21, 2023 · 4 comments · Fixed by #84

Comments

@mwestphal
Copy link

Although BSD license and GPL license are present in the repository, they seem to be missing from the binary package.

It contains the README.md that mentions the license in explicit terms but the licenses themselves are missing.

@Croydon
Copy link
Contributor

Croydon commented Jan 16, 2025

I have fixed this via #84

But there haven't been any new releases since then

@mwestphal
Copy link
Author

Sounds like a release is due then :)

@GitMensch GitMensch linked a pull request Jan 16, 2025 that will close this issue
@GitMensch
Copy link
Collaborator

@Croydon I've reached out to Alex and hope I hear back from him. If not then I may still make a minor release (having flex or bison updated as well would be preferable, of course, but we can skip this as well). When doing a new release I'll also update the choco definitions.

But... maybe you want to give adding a GH action a try which does build release+debug testing builds from each commit (and do at least a partial automated testing of the resulting binaries, if possible)? I guess that may be relative easy with your cmake packaging addition, but I commonly build only on GNU/Linux (possibly WSL) these days.

@Croydon
Copy link
Contributor

Croydon commented Jan 17, 2025

Give me some time to look into actionable improvements. No promises though, as I should be focused on other stuff 🙈

Croydon added a commit to Croydon/winflexbison that referenced this issue Jan 17, 2025
This change, plus the changes applied in lexxmark#84 fixes lexxmark#94
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants