handle cancelled tests #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@oubiwann let me know what you think when you get a chance. |
| It is disabled because normally you want | ||
| to see the test suite finishing without | ||
| errors. | ||
| " |
There was a problem hiding this comment.
I'd suggest moving this " to the previous line :)
There was a problem hiding this comment.
I thought you said to make it a docstring doesn't a module docstring go right after defmodule?
There was a problem hiding this comment.
Edited: I mean the ". All my comments are very silly here.
There was a problem hiding this comment.
Ahh I finally get it :) hehe; I'll move it up.
|
LGTM |
|
This is fantastic -- thanks for doing this, @erlanger! Such a long time coming ... |
oubiwann
added a commit
that referenced
this pull request
Oct 25, 2016
Handle the case of cancelled tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This covers cancelled tests, which
eunithandles butltestwas not. It solves some of the problems mentioned in issue #49.ltest-listenerwas ignoring thehandle_cancelcallback, simply returning the state; which is a little dangerous because it can make you think that all the tests passed. This patch solves that problem.This patch prints the same messages as
eunit.