Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Menu burger modifications #947

Closed
Kevils opened this issue Dec 24, 2024 · 22 comments · Fixed by #997
Closed

Menu burger modifications #947

Kevils opened this issue Dec 24, 2024 · 22 comments · Fixed by #997
Assignees
@BlessingEmejulu
Labels
Good first issue Good for newcomers OD Boost Issue reserved for the OD Boost Open for contribution An issue that is available for an Only Dust contribution

Comments

@Kevils
Copy link
Collaborator

Kevils commented Dec 24, 2024

Description 📹

Current one :
image

New design :
image

Figma file : https://www.figma.com/design/S1UKYgWewNqNHZFAaBUilG/%F0%9F%8F%9D%EF%B8%8F-Starknet-ID?node-id=4097-32518&t=wEy6O4uIMpUixad7-1

Modify the icons with new ones and add a #CDCCCC border to the content wrapper.

Proposed Actions 🛠️

Here’s a checklist of actions to follow for resolving this issue:

  1. Fork and Create Branch:
    Fork the repository and create a new branch using the issue number:

    git checkout -b fix-[issue-number]

  2. Implement Changes:
    [Insert Code snippet if needed with a mardown todo list]

  3. Run Tests and Commit Changes:
    Make sure your changes don't break existing functionality and commit with a clear message:

    git commit -m "Fix: [Short description of the fix]"

Required 📋

To keep our workflow smooth, please make sure you follow these guidelines:

  • Assignment: Don't create a pull request if you weren’t assigned to this issue.
  • Timeframe: Complete the task within 3 business days.
  • Closing the Issue: In your PR description, close the issue by writing Close #[issue_id].
  • Review Process:
    • Once you've submitted your PR, change the label to "ready for review".
    • If changes are requested, address them and then update the label back to "ready for review" once done.
  • Testing: Test your PR locally before pushing, and verify that tests and build are working after pushing.

Thank you for your contribution 🙏

⚠️ WARNING: Failure to follow the requirements above may result in being added to the OnlyDust blacklist, affecting your ability to receive future rewards.
@Kevils Kevils added Good first issue Good for newcomers OD Boost Issue reserved for the OD Boost Open for contribution An issue that is available for an Only Dust contribution labels Dec 24, 2024
@ryzen-xp
Copy link

Can I tackle this one?

@Amarjeet325
Copy link
Contributor

I'd love to give this a go.

@SudiptaPaul-31
Copy link

Can I work on this issue? @Kevils
I am a fullstack and blockchain developer with experience for more than 1.5 years and an active contributor to starkent
My profile: https://app.onlydust.com/u/SudiptaPaul-31

ETA-1Day

@mimisavage
Copy link

Is it okay if I tackle this?

@davedumto
Copy link

Hi,
My name is David, and I am a frontend developer skilled in JavaScript, TypeScript, React.js, Next.js, and Tailwind CSS. I will update the icons with the new design specified in the Figma file and add a #CDCCCC border to the content wrapper as instructed.
I’ll ensure the changes are implemented seamlessly and tested thoroughly to maintain functionality and responsiveness. ETA: 8 hours

@Ekene001
Copy link

Could I take a shot at this? I’m a full-stack blockchain developer with over 3 years of experience working with Tailwind, React, TypeScript, and Solidity/Rust.

@chiscookeke11
Copy link

Can I work on this, please?

@Stepcu
Copy link

Stepcu commented Jan 4, 2025

Would love to tackle this!

@BlessingEmejulu
Copy link
Contributor

Can I start working on the menu burger modifications

@emarc99
Copy link
Contributor

emarc99 commented Jan 7, 2025

May I be assigned to this?

@code-stan
Copy link
Contributor

I am a creative frontend developer, keen on implementing accurate and pixel-perfect design.

@feranmiba
Copy link
Contributor

Can I attempt this issue?

@caxtonacollins
Copy link
Contributor

May I handle this issue?

@chiscookeke11
Copy link

Can I take care of this issue?

@Marchand-Nicolas
Copy link
Collaborator

Hello @BlessingEmejulu everything good ?

@BlessingEmejulu
Copy link
Contributor

BlessingEmejulu commented Jan 25, 2025 •
edited
Loading

Hello @BlessingEmejulu everything good ?

Image

Currently, facing an internal error from one of the associated third packages (lottie-react) used... will like to get the error fixed ...

@Marchand-Nicolas
Copy link
Collaborator

Currently, facing an internal error from one of the associated third packages (lottie-react) used... will like to get the error fixed ...

Do you get this problem too without any changes made to the original code ?

@caxtonacollins
Copy link
Contributor

caxtonacollins commented Jan 25, 2025 •
edited
Loading

@BlessingEmejulu, i think i solved this issue by downgrading my node version to 18. You can use nvm to switch between versions.

@BlessingEmejulu
Copy link
Contributor

Yeah, that fixed it. I downgraded the node version ...

@Marchand-Nicolas
Copy link
Collaborator

@BlessingEmejulu, i think i solved this issue by downgrading my node version to 18. You can use nvm to switch between versions.

Yes, really good suggestion. I use nvm too to easily manage that

@BlessingEmejulu
Copy link
Contributor

Image

Fixed

@Marchand-Nicolas Marchand-Nicolas mentioned this issue Jan 26, 2025
Merged
@Marchand-Nicolas
Copy link
Collaborator

Image

Fixed

I made a review on your PR, please check it

Marchand-Nicolas added a commit that referenced this issue Jan 28, 2025
@Marchand-Nicolas
Merge pull request #997 from BlessingEmejulu/fix-#947
cac1dea 
Fix #947: Menu burger modifications
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BlessingEmejulu BlessingEmejulu

Labels
Good first issue Good for newcomers OD Boost Issue reserved for the OD Boost Open for contribution An issue that is available for an Only Dust contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #947: Menu burger modifications BlessingEmejulu/app.starknet.id