-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Building this repository using webhook #31
Comments
This is the missing piece that we need to (I guess) figure out and then (hopefully) things should work, that is:
|
doubt: Please, could someone possibly share if it should be the |
Right. Probably that's right. Note that there is a delay when publishing to the GitHub pages. |
Got it. Thank you for the clarification. |
Just setup the webhook from lfortran --- after it pushes the commit into wasm_builds. |
I think we have time at our CI due to the Windows build. So add 60s delay after "git push to wasm_builds", so that GitHub has enough time to publish the page, then issue the "webhook" from the same CI task at LFortran. That should work robustly. |
Got it. |
This work flow https://github.com/lfortran/wasm_builds/actions/runs/2878330373 at |
Yes. And I wonder if we should not do automatic updates like this --- it seems very fragile. We could create a PR after 120s in this repository, that updates the hash. Then we do not need to setup any webhooks, we just create a PR, and the CI in this repository will run and upload a testing website and we can manually review that everything works, and then just merge manually. And if we want things to work automatically, we can later set "merge if pipeline succeeds" button at the PR. So I think that is a better design, more robust. What do you think? |
It seems #24 might be a possible solution.
Automated commits might/would have looked nice. Though, this approach also seems fine. |
I am not opposed, but I am worried about the complexity / fragility. It's hard to add just one latest commit automatically, so far we didn't manage. So the PR approach seems like something that we can manage, and we can iteratively improve it (up to and including full automation), while being 100% robust at every step all the time. |
Looks like it can be done: https://kontent.ai/blog/how-to-trigger-github-action-using-webhook-with-no-code/
Originally posted by @certik in #3 (comment)
The text was updated successfully, but these errors were encountered: