Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TestFlight feedback] Fix multiline error in headline on WelcomeView #96

Open
lgerhardt45 opened this issue Jul 5, 2020 · 2 comments
Open
Labels
user feedback Issues reported by (Test) Users

Comments

@lgerhardt45
Copy link
Owner

See the attached screenshot which shows the error with the "Hello" headline on the WelcomeView. The TestFlight user has an iPhone XR (and the bug didn't appear on any other device). Please make sure that the headline label is shown correctly on all supported devices.

screenshot_01

@lennoxjay
Copy link
Collaborator

image

I have an iPhone XR and don’t see the issue - maybe the user has the zoom text function enabled?

@lennoxjay lennoxjay added the user feedback Issues reported by (Test) Users label Jul 6, 2020
@lgerhardt45
Copy link
Owner Author

Ah, yes, this is connected to the system Font size set by the user in the settings: Einstellungen -> Anzeige und Helligkeit -> Schriftgröße. Also for this problem, there‘s a solution in the new SwiftUI/Xcode version in which you can see how the UI behaves with the different settings.

This is also the reason why the font size for any text in the UI should not be set to a constant. Apple automatically scales the text up according to the user settings (and pretty sure on the iPad, too). @annalena94 we‘d need to go over this again at some point 🤗

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
user feedback Issues reported by (Test) Users
Projects
None yet
Development

No branches or pull requests

2 participants