forked from apache/pulsar
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pulsar Rate Limiter refactoring #163
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lhotari
force-pushed
the
lh-rate-limiter-refactoring
branch
from
December 2, 2023 21:07
871d9e7
to
e396cd4
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #163 +/- ##
============================================
+ Coverage 72.80% 73.38% +0.57%
- Complexity 32381 32674 +293
============================================
Files 1888 1891 +3
Lines 140298 140494 +196
Branches 15420 15455 +35
============================================
+ Hits 102144 103099 +955
+ Misses 30063 29324 -739
+ Partials 8091 8071 -20
Flags with carried forward coverage won't be shown. Click here to find out more.
|
lhotari
force-pushed
the
lh-rate-limiter-refactoring
branch
from
December 5, 2023 22:18
e2df2a8
to
cdda149
Compare
… volatile int field
…ishBufferSizeInMB
…ng duration directly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://codingthestreams.com/pulsar/2023/11/22/pulsar-slos-and-rate-limiting.html#solution-proposal