Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix][broker] Fix leader election when the advertised address is configured #170

Closed

Conversation

lhotari
Copy link
Owner

@lhotari lhotari commented Jan 12, 2024

No description provided.

@lhotari lhotari force-pushed the lh-fix-leaderbroker-election-with-advertised-address branch from a89b796 to 5856df8 Compare January 13, 2024 00:00
Copy link

codecov bot commented Jan 13, 2024

Codecov Report

Attention: 305 lines in your changes are missing coverage. Please review.

Comparison is base (f51e7ef) 72.80% compared to head (daa7cec) 73.59%.
Report is 220 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #170      +/-   ##
============================================
+ Coverage     72.80%   73.59%   +0.78%     
+ Complexity    32381    32341      -40     
============================================
  Files          1888     1859      -29     
  Lines        140298   138266    -2032     
  Branches      15420    15156     -264     
============================================
- Hits         102144   101752     -392     
+ Misses        30063    28634    -1429     
+ Partials       8091     7880     -211     
Flag Coverage Δ
inttests 24.14% <27.93%> (?)
systests 23.77% <25.01%> (-0.90%) ⬇️
unittests 72.87% <83.53%> (+0.68%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...a/org/apache/bookkeeper/mledger/ManagedLedger.java 0.00% <ø> (ø)
...pache/bookkeeper/mledger/offload/OffloadUtils.java 77.47% <100.00%> (ø)
...che/bookkeeper/mledger/offload/OffloaderUtils.java 63.23% <ø> (ø)
...ookie/rackawareness/BookieRackAffinityMapping.java 80.85% <100.00%> (+0.13%) ⬆️
...org/apache/pulsar/broker/ServiceConfiguration.java 99.39% <100.00%> (+<0.01%) ⬆️
...authentication/AuthenticationDataSubscription.java 64.28% <100.00%> (+2.74%) ⬆️
...ar/broker/authorization/AuthorizationProvider.java 18.51% <ø> (+9.25%) ⬆️
...ker/authorization/PulsarAuthorizationProvider.java 68.61% <100.00%> (+0.19%) ⬆️
.../pulsar/broker/resources/LoadBalanceResources.java 100.00% <100.00%> (ø)
...pache/pulsar/broker/resources/PulsarResources.java 84.78% <100.00%> (ø)
... and 106 more

... and 258 files with indirect coverage changes

@lhotari lhotari closed this Jan 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant