Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Limit motor speed in reverse #353

Open
KnockbackNemo opened this issue Sep 22, 2023 · 0 comments · May be fixed by #360
Open

Limit motor speed in reverse #353

KnockbackNemo opened this issue Sep 22, 2023 · 0 comments · May be fixed by #360
Assignees
@aidenmadaffri
Labels
enhancement New feature or request M2

Comments

@KnockbackNemo
Copy link
Contributor

Currently there's no software limit to how fast we can go in reverse, but we might want to add one.

This is a proposed solution to the fact that there's no velocity check when going from brake state to forward gear. This means if we go 40 MPH in reverse, move the switch to forward, and then brake, then upon release of the brake, pushing the accelerator pedal results in us (attempting) to go forward.
@Cam0Cow Cam0Cow added the enhancement New feature or request label Sep 23, 2023
@aidenmadaffri aidenmadaffri linked a pull request Sep 30, 2023 that will close this issue
Open
13 tasks
@IshDeshpa IshDeshpa added the M2 label Jan 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aidenmadaffri aidenmadaffri

Labels
enhancement New feature or request M2
Projects
Controls M2.1 Release
Status: No status
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Limit Motor Speed in Reverse lhr-solar/Controls
4 participants
@aidenmadaffri @Cam0Cow @IshDeshpa @KnockbackNemo