address comments

Signed-off-by: lhy1024 <[email protected]>
lhy1024 · Sep 14, 2023 · 98a573b · 98a573b
1 parent 40f129f
commit 98a573b
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 2 deletions.
diff --git a/server/api/server.go b/server/api/server.go
@@ -64,6 +64,8 @@ func NewHandler(_ context.Context, svr *server.Server) (http.Handler, apiutil.AP
 				scheapi.APIPathPrefix+"/schedulers",
 				mcs.SchedulingServiceName,
 				[]string{http.MethodGet}),
+			// TODO: we need to consider the case that v1 api not support restful api.
+			// we might change the previous path parameters to query parameters.
 		),
 		negroni.Wrap(r)),
 	)

diff --git a/tests/pdctl/operator/operator_test.go b/tests/pdctl/operator/operator_test.go
@@ -253,7 +253,7 @@ func TestOperator(t *testing.T) {
 	})
 }
 
-func TestMicroservice(t *testing.T) {
+func TestOperatorInMicroservice(t *testing.T) {
 	re := require.New(t)
 	ctx, cancel := context.WithCancel(context.Background())
 	defer cancel()

diff --git a/tests/pdctl/scheduler/scheduler_test.go b/tests/pdctl/scheduler/scheduler_test.go
@@ -531,7 +531,7 @@ func mightExec(re *require.Assertions, cmd *cobra.Command, args []string, v inte
 	json.Unmarshal(output, v)
 }
 
-func TestMicroservice(t *testing.T) {
+func TestSchedulerInMicroservice(t *testing.T) {
 	re := require.New(t)
 	ctx, cancel := context.WithCancel(context.Background())
 	defer cancel()