Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JOSS Review] Paper and statement of need #183

Closed
mbarzegary opened this issue Oct 16, 2023 · 2 comments
Closed

[JOSS Review] Paper and statement of need #183

mbarzegary opened this issue Oct 16, 2023 · 2 comments

Comments

@mbarzegary
Copy link

Dear authors,

The provided paper is comprehensive and well-written. However, these comments may help improve it:

  • As mentioned in the paper, there exists other packages for multi-scale coupling such as LibMultiScale and MultiBench, but the necessity of the proposed package is not well elaborated. Since it’s the most important paragraph of the statement of need, I appreciate it if the authors elaborate on this.
  • I see duplicate references. For example, there are two identical Seidel et al. (2021a and 2021b). Can you please check the paper for this?
  • The authors have referred to 2 papers using the coupling of the numerical models of the Poisson–Nernst–Planck equation in electrochemistry (Hörmann et al., 2023; Seidl et al. 2021b), but it doesn't seem that those papers use this coupling. Can you please elaborate on the mentioned usage?

P.S. This issue is related to openjournals/joss-reviews#5668

@pastewka
Copy link
Collaborator

pastewka commented Jan 4, 2024

Dear @mbarzegary - we have addressed your comments, see below:

  • As mentioned in the paper, there exists other packages for multi-scale coupling such as LibMultiScale and MultiBench, but the necessity of the proposed package is not well elaborated. Since it’s the most important paragraph of the statement of need, I appreciate it if the authors elaborate on this.

I have updated that paragraph. Essentially, most coupling tools deal with mesh interpolation and not with construction of atomic domains. I hope that this is now clearer from the description. I've also added preCICE and MpCCI as examples for generic multi-scale coupling tools in addition to the atomistic-continuum tools mentioned already in the prior iteration of the paper.

  • I see duplicate references. For example, there are two identical Seidel et al. (2021a and 2021b). Can you please check the paper for this?

This was a good catch. We fixed this.

  • The authors have referred to 2 papers using the coupling of the numerical models of the Poisson–Nernst–Planck equation in electrochemistry (Hörmann et al., 2023; Seidl et al. 2021b), but it doesn't seem that those papers use this coupling. Can you please elaborate on the mentioned usage?

This is correct, they don't use the coupling. The paper were just quoted as example of discrete (atomic-scale) effects that need to be captured. We agree that this is confusing and have removed those citations.

@pastewka
Copy link
Collaborator

pastewka commented Jan 4, 2024

PS: The changes are in the still open PR #208 and not yet in the PDF on the JOSS review page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants