Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to pybind11 #96

Open
pastewka opened this issue Mar 7, 2022 · 4 comments
Open

Switch to pybind11 #96

pastewka opened this issue Mar 7, 2022 · 4 comments
Assignees
@pastewka
Labels
question

Comments

@pastewka
Copy link
Collaborator

pastewka commented Mar 7, 2022

Should we switch the C code to C++ and pybind11? My guess is this would lead to a C++ code that is half the size of what we have currently, but we would have a dependency on pybind11 (which is actually just a bunch of C++ headers).
@jameskermode
Copy link
Member

I don't have any objection to this. We already have some C++ code so there are no further portability concerns beyond the pybind11 dependency.

@pastewka
Copy link
Collaborator Author

pastewka commented Mar 7, 2022

Okay, I'll see if can make room to do this. It would greatly simplify many aspects of the interface (and make it more robust also with respect to type confusion issues, i.e. #95)

@jameskermode jameskermode mentioned this issue Sep 27, 2022
Closed
@pastewka
Copy link
Collaborator Author

We should probably switch the build system first, see #116

@pastewka pastewka changed the title Switch to pybind11? Switch to pybind11 Nov 24, 2022
@pastewka pastewka mentioned this issue Nov 24, 2022
Open
@pastewka pastewka self-assigned this Dec 20, 2022
@pastewka
Copy link
Collaborator Author

Will take care of this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pastewka pastewka

Labels
question
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jameskermode @pastewka