Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fullscreen not scaling correctly after #1412 [MacOS] #1415

Closed
MarkOates opened this issue Mar 2, 2023 · 3 comments · Fixed by #1416
Closed

Fullscreen not scaling correctly after #1412 [MacOS] #1415

MarkOates opened this issue Mar 2, 2023 · 3 comments · Fixed by #1416

Comments

@MarkOates
Copy link
Contributor

MarkOates commented Mar 2, 2023 •
edited
Loading

After pulling and building mater, ALLEGRO_FULLSCREEN ALLEGRO_FULLSCREEN_WINDOW is not scaling correctly since #1412. Probably related to a retina display?

Expected:

expected

Actual:

actual

Windowed mode appears to work fine:

windowed

[edit: replaced large filesize images]
[edit: replaced ALLEGRO_FULLSCREEN with ALLEGRO_FULLSCREEN_WINDOW in comment]
@MarkOates MarkOates mentioned this issue Mar 2, 2023
Merged
@allefant
Copy link
Contributor

allefant commented Mar 4, 2023

Oh weird. That's kinda how it was broken before (when not drawing bitmaps/fonts at least). I thought my change only affected window resizing and left fullscreen untouched, I'll see if I can reproduce somehow.

@allefant allefant mentioned this issue Mar 4, 2023
Merged
@allefant
Copy link
Contributor

allefant commented Mar 4, 2023

Yeah, after I realized you meant ALLEGRO_FULLSCREEN_WINDOW and not ALLEGRO_FULLSCREEN I was able to reproduce!

@MarkOates
Copy link
Contributor Author

Yeah, after I realized you meant ALLEGRO_FULLSCREEN_WINDOW and not ALLEGRO_FULLSCREEN I was able to reproduce!

Yes! Sorry for that oversight. I don't think I use ALLEGRO_FULLSCREEN anywhere anymore just because it could be destructive to the user's display/settings.

Thank you for that very fast fix. 😳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

missed a spot that needs setup_gl in the last PR allefant/allegro5
2 participants
@allefant @MarkOates