Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup ParserBase default implementations #250

Open
pbauman opened this issue Jun 25, 2018 · 0 comments
Open

Cleanup ParserBase default implementations #250

pbauman opened this issue Jun 25, 2018 · 0 comments

Comments

@pbauman
Copy link
Member

pbauman commented Jun 25, 2018

ParserBase is meant to define API. So instead of everything being not implemented by default, let's make them pure virtual (where appropriate) and then let derived classes show not implemented. I think this is much more self-documenting.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pbauman