Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Network tests failing. #602

Open
thecodefactory opened this issue Oct 5, 2018 · 7 comments
Open

Network tests failing. #602

thecodefactory opened this issue Oct 5, 2018 · 7 comments
Assignees
Labels
Milestone

Comments

@thecodefactory
Copy link
Member

Just realized that network tests have been disabled for some time and should be re-enabled.

@thecodefactory thecodefactory added this to the 4.0 milestone Oct 5, 2018
@thecodefactory thecodefactory self-assigned this Oct 5, 2018
@evoskuil
Copy link
Member

evoskuil commented Oct 5, 2018

Yes/no. Network tests are not reliable as unit tests.

@thecodefactory
Copy link
Member Author

Agreed, also required is a version4 community server. But I at least want to enable it to ensure the tests can complete in testing, so more a reminder.

@thecodefactory thecodefactory changed the title Re-enable network tests Verify network tests before v4 release Oct 5, 2018
@evoskuil
Copy link
Member

evoskuil commented Jan 7, 2019

Changing this to a bug. Network tests are still failing.

@evoskuil evoskuil changed the title Verify network tests before v4 release Network tests failing. Jan 7, 2019
@thecodefactory
Copy link
Member Author

Changing this to a bug. Network tests are still failing.

IIRC, many of the failing tests require payment indexing and a v4 server at this point. I agree it's a bug, but maybe temporarily we can allocate some additional domain pointers for v4 mainnet/testnet? Speaking of which, is there are a plan to deprecate v3 mainnet/testnet domains while transitioning over, or will they just be replaced at some specified point?

@evoskuil
Copy link
Member

evoskuil commented Jan 7, 2019

Sorry, kind of rushing through triage and forgot what the deal was here. We’ll just replace the community servers on release - after an announcement to the lists.

@thecodefactory
Copy link
Member Author

Ping on network tests being broken. We need v4 mainnet/testnet servers up for these to work (or identify if they're not working yet). I think we have some mainnet v4 servers coming online at some point in the future, can look into.

@evoskuil
Copy link
Member

evoskuil commented Mar 6, 2021

Need to get v4 server out first, working on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants