Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create witness-encode and witness-decode commands. #646

Open
evoskuil opened this issue Oct 25, 2019 · 6 comments
Open

Create witness-encode and witness-decode commands. #646

evoskuil opened this issue Oct 25, 2019 · 6 comments
Assignees
Milestone

Comments

@evoskuil
Copy link
Member

evoskuil commented Oct 25, 2019

This will require a new system::config::witness class for parsing/serialization, which will also support a new --witness option for input-set. The system::chain::witness class already incorporates a canonical textual serialization (as bracketed base16-encoded data tokens) and wire encoding with optional prefix (variable integer element count). This should be extended to include a from_string(...) method for parsing the canonical textual serialization.

A transaction incorporates an optional witness stack. These commands will support just one element of that stack and as such require no prefix (element count). The prefix is not allowed when encoding. The prefix should be made a flag (option) when decoding, defaulted to true as this is considered part of the witness. Each token is variable integer byte-prefixed as well.

@evoskuil evoskuil added this to the 4.0 milestone Oct 25, 2019
@evoskuil evoskuil self-assigned this Oct 25, 2019
@praveenbm5
Copy link

Any updates on this?

@evoskuil
Copy link
Member Author

Still on the short plan, but lots of housecleaning to get out first.

@evoskuil
Copy link
Member Author

I'm back to full time on libbitcoin, so things are starting to move a lot more quickly.

@praveenbm5
Copy link

Thats great news! BX and Bitcoin needs you.

Is there anyway I can help?

@evoskuil
Copy link
Member Author

Sure, create a pull request!

@evoskuil
Copy link
Member Author

I'm glad I wrote the notes above, it's been a while.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants