Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmake_minimum_required(...) has a wrong version required #325

Open
woniua opened this issue Mar 3, 2021 · 2 comments
Open

cmake_minimum_required(...) has a wrong version required #325

woniua opened this issue Mar 3, 2021 · 2 comments

Comments

@woniua
Copy link

woniua commented Mar 3, 2021 •
edited
Loading

In tag '0.15.2' and later, the cmake_minimum_required(...) is version 3.9 required in top level CMakeLists.txt, In this file, the funcion add_link_options(...) is invoked at line 251 and it`s news from CMAKE version 3.13.

Does the cmake_minimum_required(...) should correct into cmake_minimum_required(VERSION 3.13)?
@mikkoi
Copy link
Contributor

mikkoi commented Mar 13, 2021

Hi.
Yes. That's clearly wrong. CMake minimum version should be raised to 3.13.
Thanks for noticing it.
Could you make a pull request?

mikkoi added a commit to mikkoi/check that referenced this issue Sep 19, 2021
@mikkoi
Update CMake required from 3.9 to 3.13
8477ac1 
libcheck#325

    cmake_minimum_required(...) is version 3.9 required in top level CMakeLists.txt, In this file, the funcion add_link_options(...) is invoked at line 251 and it`s news from CMAKE version 3.13.
@mikkoi mikkoi mentioned this issue Sep 19, 2021
Merged
@mikkoi
Copy link
Contributor

mikkoi commented Sep 19, 2021

Fixed in PR #338

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mikkoi @woniua