diff --git a/CMakeLists.txt b/CMakeLists.txt index 7fe4635f6..5af365768 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -280,12 +280,6 @@ else() restore_variable(DESTINATION CMAKE_CXX_CLANG_TIDY BACKUP CMAKE_CXX_CLANG_TIDY_BKP) endif() -# Add the NOMINMAX macro for windows to curl to prevent issues with std::min and std::max down the line. -# Ref: https://github.com/libcpr/cpr/issues/957 -if(WIN32) - target_compile_definitions(CURL::libcurl PUBLIC NOMINMAX) -endif() - # GTest configuration if(CPR_BUILD_TESTS) if(CPR_USE_SYSTEM_GTEST) diff --git a/cpr/CMakeLists.txt b/cpr/CMakeLists.txt index 52787f56a..788ad9535 100644 --- a/cpr/CMakeLists.txt +++ b/cpr/CMakeLists.txt @@ -32,6 +32,12 @@ add_library(cpr add_library(cpr::cpr ALIAS cpr) +# Add the NOMINMAX macro for windows to curl to prevent issues with std::min and std::max down the line. +# Ref: https://github.com/libcpr/cpr/issues/957 +if(WIN32) + target_compile_definitions(cpr PUBLIC NOMINMAX) +endif() + target_link_libraries(cpr PUBLIC CURL::libcurl) # todo should be private, but first dependencies in ssl_options need to be removed # Fix missing OpenSSL includes for Windows since in 'ssl_ctx.cpp' we include OpenSSL directly