Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rid of is_suspicious #60

Closed
Changaco opened this issue Jan 5, 2016 · 8 comments
Closed

Get rid of is_suspicious #60

Changaco opened this issue Jan 5, 2016 · 8 comments
Assignees
Labels
good first issue suitable for new contributors

Comments

@Changaco
Copy link
Member

Changaco commented Jan 5, 2016

While writing the Terms of Service (liberapay/liberapay.org#4) it occurred to me that blacklisting users without notifying them and with no time limit is very bad. #58 and #59 are how we should handle fraud.

@Changaco Changaco added the good first issue suitable for new contributors label Jan 5, 2016
@Changaco
Copy link
Member Author

Changaco commented Jan 6, 2016

Anyone up for this? It should be pretty easy: git grep suspicious and modify or remove the relevant files. Same for git grep blacklist.

@Changaco Changaco assigned Changaco and unassigned Changaco Jan 25, 2016
@MartinDelille MartinDelille self-assigned this Feb 7, 2016
@MartinDelille
Copy link
Contributor

I working on this. In order to understand the admin part, how do we access the admin account when using fake data in the local env?

@Changaco
Copy link
Member Author

Changaco commented Feb 7, 2016

psql liberapay -c "update participants set is_admin = true where username = '<your-username>'"

@Changaco
Copy link
Member Author

Changaco commented Feb 7, 2016

Although if you're talking about www/dashboard/index.spt, we can actually remove that completely, along with admin.js and test_is_suspicious.py.

@MartinDelille
Copy link
Contributor

shall I clean the translation file for 'blacklist' ?

@MartinDelille
Copy link
Contributor

In fact 'blacklist' is mentioned only in the about page. Shall I remove the reference to 'blacklist' there? Will the translation files be updated if a string has been removed? How? Otherwiwe how do we clean translation?

MartinDelille added a commit that referenced this issue Feb 7, 2016
@Changaco
Copy link
Member Author

Changaco commented Feb 7, 2016

Don't modify the .po files in a PR, it could result in conflicts on Weblate (see 5th item of #75), they're updated automatically when we sync translations (make i18n_update).

@Changaco
Copy link
Member Author

Changaco commented Feb 7, 2016

Shall I remove the reference to 'blacklist' there?

Yes.

Changaco added a commit that referenced this issue Feb 9, 2016
get rid of suspicious suspicious and blacklist fix #60
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue suitable for new contributors
Development

No branches or pull requests

2 participants