Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't bring service to 0 when not all rollback instances are unhealthy #97

Open
rdbatch opened this issue Feb 4, 2020 · 0 comments
Open
Labels
bug Something isn't working

Comments

@rdbatch
Copy link
Contributor

rdbatch commented Feb 4, 2020

When rolling back after what looks like a failed deployment, Herman should let instances that rolled back successfully to stay alive in the event that the rollback fails due to cluster instance specific issues. As it stands today, a rollback that only partially fails will have the service desiredCount set to 0, causing an outage instead of degraded service.

@rdbatch rdbatch added the bug Something isn't working label Feb 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants
@rdbatch and others