Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PooledEngine is not extensible #255

Open
fatalcubez opened this issue Jan 21, 2017 · 0 comments
Open

PooledEngine is not extensible #255

fatalcubez opened this issue Jan 21, 2017 · 0 comments

Comments

@fatalcubez
Copy link

I posted a while ago an issue about the PooledEngine not having the option to allow for removal of components without freeing them up in the pool, and that question was ignored.

Since this feature doesn't seem to be wanted in the main library (which is understandable), I thought I would take a crack at making my own PooledEngine with the feature put in. However, this seems impossible for the following reasons:

  1. As is, the PooledEngine uses private inner classes which you can't extend or wrap to change behavior or add functionality (i.e. I would like to extend PooledEntity so I could add in the ability for the user to choose whether or not when removing a component that component is reset)

  2. If you try to create your own PooledEngine it's not possible due to the use of package private variables in the Entity class (scheduledForRemoval and removing)

If I can't wrap/extend PooledEngine or recreate it and my original post's suggestion won't be implemented, then I have no idea how I can get the functionality I need out of the PooledEngine.

I hope this post doesn't come across as too aggressive (sincerely not what I'm going for), but rather as a legitimate concern. If you don't want to go with my original idea, then can at least the PooledEngine be opened up for extensibility without having to jump through so many hoops?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant