-
Notifications
You must be signed in to change notification settings - Fork 218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Versions page is or will be outdated #203
Comments
At the moment, there is a plugin which fetches the versions from gdx-setup's DependencyBank file. We should be able to change that to fetch the data from some file in the liftoff repo, if so desired. |
I guess what we need to decide first is, whether we want to keep the versions page around. Does anyone even use that? |
I'm not really sure what purpose it serves. Even if it were to be updated with gdx-liftoff's defaults, that's all they are - defaults. Often you can use newer versions just fine, especially if using a recent version of Android Studio since the setup tools have always held back on AGP for IntellIJ IDEA compatibility. And no-one wants to update a setup tool with each patch version bump. The most recent mention of it from someone who isn't me was in 2022 and there's not a single mention of |
To pitch in, the idea is that these are the tested combinations that work. IDEA/AS constantly pump you notifications to update, which can completely break libgdx projects because of gradle compatibilities mainly with the other plugins we use. robovm/gwt. Obviously this is meaningless if its not maintained, but its for people that have existing projects to see what are the latest versions of all the tools that are tested to be working when you have all of the official platforms enabled in a gradle build. |
However, these combinations have not been tested currently and do not work. Case in point, it says GWT 2.8.2 is used, and that isn't true for gdx-setup or gdx-liftoff... |
Devil's advocate: It's true for the stable version of gdx-setup. Which is no longer distributed (307791b). |
If we decide to keep it, is there a file in gdx-liftoff, where we could fetch these versions from, @tommyettinger? |
I would look in the generated template/sample projects produced for the most recent stable version. Most are here, https://github.com/libgdx/gdx-liftoff-demo/blob/main/gradle.properties , but some other versions are really not meant to be updated separately from Liftoff because they can break things if updated. These include AGP ( https://github.com/libgdx/gdx-liftoff-demo/blob/main/build.gradle#L12 , which IDEA and AS can only update automatically if it is a hardcoded version and not a property ), Gretty ( https://github.com/libgdx/gdx-liftoff-demo/blob/main/html/build.gradle#L7 , which generally doesn't need updating, and the 3.x branch might not even be updated anymore...), and Gradle itself ( https://github.com/libgdx/gdx-liftoff-demo/blob/main/gradle/wrapper/gradle-wrapper.properties , which has already been updated to 8.9). |
Ahh darn, some of the demo projects still depend on this for their dependencies, e.g. libgdx-demo-superjumper. So we have to tackle this as well if we decide to drop the versions API. |
I don't think the demos have a good solution there. I haven't been able to build that version of Super Jumper due to its age, but automatically using the latest (or second-latest in our case, since the API is wrong) version is a reckless move. Major releases of libGDX have breaking changes. For example, the next version of libGDX will break the GWT module (if it isn't already broken - |
Regarding superjumper, I've almost finished a PR that will update it by rebuilding it with gdx-liftoff (see https://github.com/SonicGDX/superjumper-recreate). I'm currently testing it right now to make sure I've transferred everything over properly (made a few changes to things like the iOS launch image and the icons) |
For now, the versions page is retired, fc3ead0. |
With Liftoff here to stay, https://libgdx.com/dev/versions/ is doing a worse job at listing versions than ever before.
What will its fate be? Maintain or delete? You decide!
The text was updated successfully, but these errors were encountered: