Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

flaky TestSkipRefreshOnGapCpls test #722

Open
marten-seemann opened this issue Jun 14, 2021 · 1 comment
Open

flaky TestSkipRefreshOnGapCpls test #722

marten-seemann opened this issue Jun 14, 2021 · 1 comment
Labels
kind/bug A bug in existing code (including security flaws)

Comments

@marten-seemann
Copy link
Contributor

When running with race detector. Timing issue?

 === RUN   TestSkipRefreshOnGapCpls
      rt_refresh_manager_test.go:42: 
          	Error Trace:	rt_refresh_manager_test.go:42
          	            				rt_refresh_manager.go:298
          	            				rt_refresh_manager.go:279
          	            				rt_refresh_manager.go:212
          	            				rt_refresh_manager.go:234
          	            				rt_refresh_manager_test.go:89
          	Error:      	Should be true
          	Test:       	TestSkipRefreshOnGapCpls
  --- FAIL: TestSkipRefreshOnGapCpls (0.00s)
  FAIL
  FAIL	github.com/libp2p/go-libp2p-kad-dht/rtrefresh	0.056s
@marten-seemann marten-seemann added the kind/bug A bug in existing code (including security flaws) label Jun 14, 2021
@marten-seemann
Copy link
Contributor Author

Probably not a timing issue. I can reliably reproduce this locally by running the tests with -count=100.

@marten-seemann marten-seemann mentioned this issue Jun 14, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug A bug in existing code (including security flaws)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@marten-seemann