Autonat doesn't support multiple addresses well

[nazar-pc]

Right now autonat sends concatenation of other_addresses and listen_addresses, which are always processed in the same order by receiving side:

rust-libp2p/protocols/autonat/src/behaviour/as_client.rs

Lines 188 to 206 in caf9da4

	let addresses = self
	.other_candidates
	.iter()
	.chain(self.listen_addresses.iter())
	.cloned()
	.collect();
	let probe_id = self.probe_id.next();
	let event = match self.do_probe(probe_id, addresses) {
	Ok(peer) => OutboundProbeEvent::Request { probe_id, peer },
	Err(error) => {
	self.handle_reported_status(NatStatus::Unknown);
	OutboundProbeEvent::Error {
	probe_id,
	peer: None,
	error,
	}
	}
	};

If my understanding of the code is correct, only the first successfully dialed address will be returned.

This is problematic in case of multiple addresses though:

• out of multiple public addresses only the first one will be confirmed
• mix of public and private addresses doesn't seem to play very nicely with this either

I think the solution here is that either sender of the probe or receiver should shuffle addresses such that we check different addresses.

I'm not very familiar with autonat right now to understand if it is architecturally supposed to support this use case at all since confirmations will be done for different addresses in different calls.

[mxinden]

AutoNATv2 will allow us to probe addresses individually.

Instead of optimizing AutoNATv1, I suggest we tackle this as part of #4524.

[guillaumemichel]

@umgefahren is this issue addressed by AutoNAT v2?

[umgefahren]

At this moment this is not addressed. We don't shuffle the addresses as it stands. We considered shipping this in the future though.