Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ambiguity in ECDSA and secp256k1 implementation #540

Open
drHuangMHT opened this issue Apr 13, 2023 · 0 comments
Open

Ambiguity in ECDSA and secp256k1 implementation #540

drHuangMHT opened this issue Apr 13, 2023 · 0 comments

Comments

@drHuangMHT
Copy link

ECDSA is a kind of algorithm while secp256k1 is a kind of curve used in ECDSA. However, the two things are listed at the same level in peer-ids. And there are other kinds of curve like secp256r1 and secp384r1 that can be used in ECDSA but not mentioned in the sepc.
Therefore, I propose that we make secp256k1 support a MUST when supporting ECDSA and other curves a MAY. This also means we stop listing secp256k1 and ECDSA at the same level.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
libp2p Specs
Status: Triage
Milestone
No milestone
Development

No branches or pull requests
1 participant
@drHuangMHT