Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Users on very slow networks can fill and submit the form before wplf-form.js has loaded #122

Open
k1sul1 opened this issue Aug 16, 2018 · 2 comments
Assignees
Milestone

Comments

@k1sul1
Copy link
Member

k1sul1 commented Aug 16, 2018

I throttled my connection to "Slow 3G" in Chrome devtools, loaded a page with a form in it, filled an input and clicked select. This resulted in ?name=mirri+2&referrer=https%3A%2F%2Flibreformbuilder.local%2Fform%2F&_referrer_id=71&_form_id=114 appending to the URL, and a 404 was displayed.

I propose using display: none; on the form and removing it when the script has loaded.

@k1sul1
Copy link
Member Author

k1sul1 commented May 31, 2019

I decided to use visibility instead, and tabindex -1 with it. That should prevent all but bots from filling the form.

I'm not sure if that's what we should ship though. If you're on a real potato network, it might take many seconds before the form is visible. Maybe we should show some type of loading text if it takes more than 500ms, but I'm not sure how to implement that.

The technical side is a non-issue, it's the UX that I'm worried about.

@k1sul1 k1sul1 added this to the 2.0 milestone May 31, 2019
@k1sul1 k1sul1 self-assigned this May 31, 2019
@k1sul1
Copy link
Member Author

k1sul1 commented Jun 2, 2019

@libreform/maintainers thoughts on the loading indicator?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants