Fix refresh rate for PAL GC games with 60Hz option #311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested with Super Mario Sunshine, currently with the PAL version if you select "60Hz" in-game the core will still lock refresh rate to 50, making the audio awful and the game still running at 50 (25 internally).
I wasn't sure how to handle this so I just checked at how LRPS2 was handling this and it just reports NTSC timing no matter what in
retro_get_system_av_info, and it seems to work absolutely fine with Dolphin as well. I tried multiple PAL GC and Wii games just to make sure, switching between 50 and 60Hz, I couldn't find any problem, the core properly runs at the correct refresh rate.Also changed
PAL60core option name toPAL60 (Wii)to avoid confusion, since this setting only affects Wii games.Fixes #310