Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing GLSL shaders that are present in slang-shaders #309

Open
TuxSH opened this issue Oct 10, 2023 · 4 comments
Open

Missing GLSL shaders that are present in slang-shaders #309

TuxSH opened this issue Oct 10, 2023 · 4 comments

Comments

@TuxSH
Copy link

TuxSH commented Oct 10, 2023

Hello,

I've noticed that at least a few slangp shaders have no equivalent in this repo. I'm thinking about these ones in particular: libretro/slang-shaders@93baa7f .

Would it be possible to port them over (at least the simple colorspace-transform ones)?

Thanks

@hizzlekizzle
Copy link
Collaborator

Yes, it's very possible, I just haven't done it because it's a lot of files and I'm lazy.

@TuxSH
Copy link
Author

TuxSH commented Oct 11, 2023

For the ags-101 shader this should do it: https://gist.github.com/TuxSH/1d58807e1beb86646ac1ff112da908ef I think

I've noticed there is a bug where relative paths are not properly parsed in glslp: copy-pasting the entire shader folder to anywhere else results in no shader being detected, but pasting custom glslp shaders into the default dir does result in that shader showing up. This doesn't happen with vulkan shaders.

@hizzlekizzle
Copy link
Collaborator

That's weird. I haven't experienced that :/

Shader port looks good, nice work! You probably want to remove the version directive at the top of the file unless it specifically needs one for compatibility purposes, but otherwise, perfect. Care to throw it in a pull request to the main branch?

@TuxSH
Copy link
Author

TuxSH commented Oct 16, 2023

Sure, I will do it later :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants