Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

asurabus Sound Fixes/Clone possible backport #911

Open
meowthed opened this issue Oct 30, 2020 · 7 comments
Open

asurabus Sound Fixes/Clone possible backport #911

meowthed opened this issue Oct 30, 2020 · 7 comments

Comments

@meowthed
Copy link
Collaborator

0.143u3: hap re-added YMF262 to the FuukiFG3 driver, used in the music for FM channels and fixed sound effects are looping. Brian Troha corrected dipswitches and added DIP locations to Asura Buster. Changed YMF262 clock speed to 14260547 Hz.

The game has a Review build that might be interesting.

http://adb.arcadeitalia.net/dettaglio_mame.php?game_name=asurabusa

@arcadez2003
Copy link
Collaborator

arcadez2003 commented Oct 30, 2020

Yeah i know about these changes from what i mind you cant just drop the code from 0.143u3 into the driver you also have to backport some earlier changes leading up to it, i'll look into this again real soon it's the workload required that puts me off.

Also they keep adding and removing the YMF262 to the driver and making changes to the soundcore so i dunno if MAMEdev
are 100% on what sound cores this game should use, anyway i'll focus on trying to stop the sound from looping that fix
needs to be made in the sound core rather than the driver by looks.

@arcadez2003
Copy link
Collaborator

Right this is the commit we need............

arcadez2003/mame@8323f49#diff-83d91be2e3c59e89b1510c178c850c662844bf2a8b630508c544eeb3a0ea9f73

I might be able to backport the code to this core i wont know till i've looked at it in more depth

@arcadez2003
Copy link
Collaborator

arcadez2003 commented Oct 30, 2020

Ok as i said sometimes you cant just drop in code from a certain MAME build, as for it to slot in correctly you have to
add all the previous commits, everyone of these from happppp will be required firstly...........

https://github.com/arcadez2003/mame/commits/8323f492df8d981c2d1b9ba8bd069b8ddf60bd20?before=8323f492df8d981c2d1b9ba8bd069b8ddf60bd20+35&branch=8323f492df8d981c2d1b9ba8bd069b8ddf60bd20&path%5B%5D=src&path%5B%5D=emu&path%5B%5D=sound&path%5B%5D=ymf278b.c

This code being from after the huge soundcore update circa MAME93 would then have to be reworked to MAME78
standards, so effectively a huge workload to begin with then doubles, so you can understand why i have not fixed
the sound in Asura Buster.

Personally i just do this as a hobby it's not a full time occupation :)

Hence im not prepared to take on a job as big as this one, however maybe a bounty will give someone else the motivation
to tackle it, i plain forgot about the sound problems in this game when i added support for it to this core if i had minded
at the time i'd just not have bothered to support in MAME2003+ in the first place that would have been the easiest fix ;)

Anyway i hooked up the sound for Asura Blade in this core and it works fine so 1 outta 2 ain't all bad!!

@arcadez2003
Copy link
Collaborator

Im hoping this commit from dink might be enough to stop the repeating echos when it comes to the speech and sfx
in Asura Buster for this core..
SidonCryerd/FinalBurnNeo@6649e7b#diff-e11691ea18d978e592320a5e86b46cb153b0966fc68f9612ba6fe185ab1da7c3

This is what i've come up with....
#1819

So @grant2258 @mahoneyt944 if you guys get a spare moment sometime can you take a peek at my PR to see if
firstly i've implemented this correctly and if so does it stop certain sound repeating/ echoing in Asura Buster

@arcadez2003
Copy link
Collaborator

arcadez2003 commented Aug 13, 2024

We have no ym278b_reset so i've stuck the ymf278b_chip_in_reset on and off calls in our ym278b_init
https://github.com/SidonCryerd/FinalBurnNeo/blob/6649e7b1d0b7c70c0708eabbb51286c4fee15d63/src/burn/snd/ymf278b.c#L958

Basically that's what im most concerned about as to whether i've setup the ymf278b_chip_in_reset defines in the
correct places, anyway there are some other changes to the YM261 sound core which might be needed here to
sort the sound 100% however just stoping the sounds from double playing will be good enough for me and
likely most users.

@mahoneyt944
Copy link
Collaborator

I can test the game here shortly, I guess if it sounds ok then this PR should be ok I would think.

@arcadez2003
Copy link
Collaborator

Thanks man fingers crossed this will be enough to sort Asura Buster sound niggles

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants