Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lifting the veil for profiling data #242

Open
fwsGonzo opened this issue Dec 22, 2024 · 0 comments
Open

Lifting the veil for profiling data #242

fwsGonzo opened this issue Dec 22, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@fwsGonzo
Copy link
Collaborator

Currently stripped executables don't provide much profiling visibility, however...

The way Godot Sandbox works is that you have tons of nodes each of which perform computations through entry functions exposed through the public API. So, given a large system, just having the entry functions should yield useful information. However, whenever the profiler samples another function, let's say a private function or one from the C++ API, then there is no data to go by.

I think we can solve this by also sampling the entry address, which we have, so that if there's nothing to go by for sampling, at least the entry function should be there.

This commit adds visibility to the public API for profiling, which is step 1. Step 2 is then to also sample the entry address along with the sampled PC, and then fall back to that. Of course, all these issues evaporate once someone builds all the programs with full symbol table, but sometimes that's not possible - and imagine how useful profiling is if you can still get information even though everything is release-stripped.

@fwsGonzo fwsGonzo added the enhancement New feature or request label Dec 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant