Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question: Is it possible to add the latest version of vipsdisp to the release? #58

Open
euzada opened this issue Dec 19, 2023 · 8 comments
Labels
enhancement New feature or request

Comments

@euzada
Copy link

euzada commented Dec 19, 2023

Hi,

Than you for compiling the windows version of libvips. Is it possible to include vipsdisp to the new release as part of the default build?

Thank you.

@jcupitt
Copy link
Member

jcupitt commented Mar 4, 2024

vipsdisp is using features and fixes in the unreleased libvips 8.16, so I think this would be tricky right now. Once it becomes a bit more stable this might be possible.

For now, I'll be doing win builds for each vipsdisp release, eg. the new v3: https://github.com/jcupitt/vipsdisp/releases/tag/v3.0.4

@jcupitt
Copy link
Member

jcupitt commented Mar 4, 2024

FWIW I used the vipsdisp branch of this repo, updated libjxl to 0.10.1 (there are large performance and memory improvements), changed the vips version to 8.16, vipsdisp to 3.0.4, and built with:

./build.sh --with-disp --commit db9c535a4a8d56bab564e12f7bc14db88e82a6f9 all

To get the latest libvips fixes it needs.

@euzada
Copy link
Author

euzada commented May 1, 2024

FWIW I used the vipsdisp branch of this repo, updated libjxl to 0.10.1 (there are large performance and memory improvements), changed the vips version to 8.16, vipsdisp to 3.0.4, and built with:

./build.sh --with-disp --commit db9c535a4a8d56bab564e12f7bc14db88e82a6f9 all

To get the latest libvips fixes it needs.

Hi @jcupitt , I tried to build it using

./build.sh --with-disp --commit db9c535a4a8d56bab564e12f7bc14db88e82a6f9 all

but I get an error: Unknown option --with-disp

Any suggestion?

thank you.

@jcupitt
Copy link
Member

jcupitt commented May 1, 2024

You need the vipsdisp branch of build-win64-mxe.

@kleisauke
Copy link
Member

I'm planning to merge the vipsdisp branch as part of the libvips 8.16 release.

FWIW, I had to patch GTK to fix a weird font rendering issue, see:
https://gitlab.gnome.org/GNOME/pango/-/issues/767#note_2109293

Let's tag this as an enhancement.

@kleisauke kleisauke added the enhancement New feature or request label Sep 24, 2024
@jcupitt
Copy link
Member

jcupitt commented Sep 25, 2024

Ah great!

A nip4 target (so far anyway, the same dependencies as vipsdisp) would be very useful soon too.

Your gtk patch for win improves font rendering a lot, I should rebuild the vipsdisp binary I'm using.

@kleisauke
Copy link
Member

The vipsdisp branch has just been merged now that libvips 8.16.0-rc1 has been released.

I still need to think about how and where to distribute this. The nip4 target is also on my to-do list.

@kleisauke
Copy link
Member

... thinking about this further, I could just compile/distribute vipsdisp (more specifically the vips-dev-w64-all-*-disp variant) in this repo along with the other binaries. I just pushed d0390ad to ensure it will not collide with the other build targets.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants