New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Method defined at top level. #341

Open

ioquatix opened this issue Jun 24, 2022 · 1 comment

Member

ioquatix commented Jun 24, 2022

ruby-vips/lib/vips.rb

Line 26 in 932c31a

def library_name(name, abi_number)

This puts it in the global scope, is that a good idea?

Member

jcupitt commented Jun 24, 2022

Yes, true :(

I wanted to avoid copy-pasting it into the GLib, GModule and Vips modules. Really it ought to be inside ffi (i saw your PR, nice!).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment