Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

capture script links [enhancement, patch] #206

Open
spazm opened this issue May 8, 2017 · 4 comments
Open

capture script links [enhancement, patch] #206

spazm opened this issue May 8, 2017 · 4 comments

Comments

@spazm
Copy link
Contributor

spazm commented May 8, 2017

[email protected] reported on Jan 2, 2012

In the absence of a real perl javascript we can't actually use the content.
However I use WWW::Mechanize for testing web site logins for our monitoring
system and think it is useful to fetch script links, as problems loading
such links are usually reflected in the user experience.


--- WWW-Mechanize-1.71.orig/lib/WWW/Mechanize.pm	2011-11-26 04:33:10.000000000 +1000
+++ WWW-Mechanize-1.71/lib/WWW/Mechanize.pm	2012-01-01 08:56:59.000000000 +1000
@@ -2536,6 +2539,7 @@
     iframe => 'src',
     link   => 'href',
     meta   => 'content',
+    script => 'src',
 );
 
 sub _extract_links {

Details

Imported from Google Code issue 229 via archive

  • Type: Defect
  • Date: Jan 2, 2012
  • Reporter: [email protected]
  • Owner: ----
  • Priority: Medium
  • Status: New
@DannyThomas
Copy link

you could quibble whether it's a defect or enhancement
but is there any reason this 1-line change can't be made ?

I get reminded with each release when I have to
produce a patch corresponding to the distribution.

@oalders
Copy link
Member

oalders commented Dec 3, 2018

I think this is fine. It probably hasn't been acted on because we're low on people power.

We could speed this up process with a pull request and an accompanying test. Does that sound reasonable?

@DannyThomas
Copy link

DannyThomas commented Dec 6, 2018 via email

@oalders
Copy link
Member

oalders commented Dec 7, 2018

Hi Danny,

Take good care of yourself! We'll keep this open until it's deal with.

Olaf

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants