Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libfdata compiler warning for architectures that (still) have a 32-bit time_t #16

Closed
ant1 opened this issue Nov 24, 2018 · 9 comments
Closed
Assignees

Comments

@ant1
Copy link

ant1 commented Nov 24, 2018

When compiling libqcow 20181117 on freebsd i386, there are new warnings:

libfdata_area.c:181:7: warning: incompatible pointer types passing 'time_t *' (aka 'int *') to parameter of type 'int64_t *' (aka 'long long *') [-Wincompatible-pointer-types]
             &( internal_area->timestamp ),
             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../libfcache/libfcache_date_time.h:37:15: note: passing argument to parameter 'timestamp' here
     int64_t *timestamp,
              ^
libfdata_area.c:1084:9: warning: incompatible pointer types passing 'time_t *' (aka 'int *') to parameter of type 'int64_t *' (aka 'long long *') [-Wincompatible-pointer-types]
                             &cache_value_timestamp,
                             ^~~~~~~~~~~~~~~~~~~~~~
../libfcache/libfcache_cache_value.h:90:15: note: passing argument to parameter 'timestamp' here
     int64_t *timestamp,
              ^
libfdata_area.c:1199:9: warning: incompatible pointer types passing 'time_t *' (aka 'int *') to parameter of type 'int64_t *' (aka 'long long *') [-Wincompatible-pointer-types]
                             &cache_value_timestamp,
                             ^~~~~~~~~~~~~~~~~~~~~~
../libfcache/libfcache_cache_value.h:90:15: note: passing argument to parameter 'timestamp' here
     int64_t *timestamp,
              ^
3 warnings generated.

Some dfvfs now fail too:

RuntimeError: 'pyqcow_file_read_buffer: unable to read data. libfdata_vector_get_element_value_by_index: missing cache value. libfdata_vector_get_element_value_at_offset: unable to retrieve element: 4 value. libqcow_internal_file_read_buffer_from_file_io_handle: unable to retrieve level2 table at offset: 0x00040000. libqcow_file_read_buffer: unable to read buffer.'
@joachimmetz joachimmetz transferred this issue from libyal/libfdata Nov 24, 2018
@joachimmetz
Copy link
Member

Moved to libqcow. I'll change it to use int64_t instead of time_t.

@joachimmetz joachimmetz changed the title Regression on archs where time_t is 32 bits libfdata changes affect architectures that (still) have a 32-bit time_t Nov 24, 2018
@joachimmetz joachimmetz self-assigned this Nov 24, 2018
@joachimmetz
Copy link
Member

Looks like libqcow 20181117 alpha got bundled with an older version of libfdata.

@joachimmetz joachimmetz changed the title libfdata changes affect architectures that (still) have a 32-bit time_t libfdata compiler warning for architectures that (still) have a 32-bit time_t Nov 24, 2018
@ant1
Copy link
Author

ant1 commented Nov 24, 2018

This also affects at least last releases of libfsapfs, libvmdk, libbde

@joachimmetz
Copy link
Member

why are you packaging libfsapfs? this is still work in progress

libvmdk, libbde

ack

@ant1
Copy link
Author

ant1 commented Nov 24, 2018

I'm just testing libfsapfs, not packaging yet.

@joachimmetz
Copy link
Member

I see, know that it is still WIP. A first experimental (bleeding edge) version is likely be ready mid December and then there is more to do, to improve format support.

@joachimmetz
Copy link
Member

libfdata, libbde, libqcow and libvmdk updated. Closing issue, please reopen if issue persists.

@ant1
Copy link
Author

ant1 commented Nov 24, 2018

libvhdi version 20181118 also has warnings on freebsd i386, but dfvfs regression tests are OK.

@joachimmetz
Copy link
Member

I'll have a look at libvhdi then as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants