-
-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement api/challenge
endpoints
#52
Merged
kraktus
merged 18 commits into
lichess-org:master
from
Anupya:Anupya/add-challenge-endpoints
Nov 1, 2023
Merged
Implement api/challenge
endpoints
#52
kraktus
merged 18 commits into
lichess-org:master
from
Anupya:Anupya/add-challenge-endpoints
Nov 1, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And as mentioned in the other PR, return type annotations should ideally use TypedDict. |
Anupya
force-pushed
the
Anupya/add-challenge-endpoints
branch
from
October 23, 2023 17:44
950d552
to
3e46bb3
Compare
Co-authored-by: Benedikt Werner <[email protected]>
Anupya
force-pushed
the
Anupya/add-challenge-endpoints
branch
from
October 30, 2023 14:25
9fc7355
to
e764faa
Compare
kraktus
reviewed
Oct 31, 2023
Anupya
force-pushed
the
Anupya/add-challenge-endpoints
branch
from
November 1, 2023 18:40
e764faa
to
6f5cabc
Compare
Perfect thanks! Just a NIT: ad22b75 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add all the remaining
challenge
endpoints:get_mine
=/api/challenge
cancel
=/api/challenge/{challengeId}/cancel
start_clocks
=/api/challenge/{gameId}/start-clocks
add_time_to_opponent_clock
=/api/round/{game_id}/add-time/{seconds}
create_tokens_for_multiple_users
=/api/token/admin-challenge
Move
ChallengeDeclineReason
toberserk/types/challenges.py
asDeclineReason
.After merge
Please check off all
api/challenge/...
endpoints in the issue description for #6.