Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement external-engine endpoints #66

Conversation

Anupya
Copy link
Contributor

@Anupya Anupya commented Nov 3, 2023

Description

  • Create a new class ExternalEngineAnalysis because these 3 endpoints use a different URL and pertain to analyses which makes them functionally different from the endpoints in ExternalEngine which are just CRUD on external engine.
  • Did not add a test as they are all POST endpoints

After merge

I believe with this PR, all the endpoints in #6 (that are possible to implement) have been implemented in the client! Please check all of them off and close the issue.

Checklist

Checklist when adding a new endpoint
  • Added new endpoint to the README.md
  • Ensure that my endpoint name does not repeat the name of the client. Wrong: client.users.get_user(), Correct: client.users.get()
  • Typed the returned JSON using TypedDicts in berserk/types/, example
  • Tested GET endpoints not requiring authentification. Documentation, example <-- not GET
  • Added the endpoint and your name to CHANGELOG.md in the To be released section (to be created if necessary) <-- leaving it up to the maintainer

@Anupya Anupya marked this pull request as ready for review November 7, 2023 20:31
@kraktus
Copy link
Member

kraktus commented Nov 12, 2023

Hey, haven’t forgotten about it, just still considering if it’s best to put it in the same client as external analysis or not

@kraktus
Copy link
Member

kraktus commented Nov 15, 2023

@Anupya I think it’s best to put everything behind the external_engine client and handle the different base URL internally. iirc you said you started working again, so if you have no time will do it later.

@Anupya
Copy link
Contributor Author

Anupya commented Nov 15, 2023

I am indeed busy at work again 🙏

@Anupya Anupya closed this Nov 15, 2023
@kraktus kraktus mentioned this pull request Mar 18, 2024
78 tasks
@kraktus kraktus changed the title Implement https://engine.lichess.ovh/api/external-engine endpoints Implement external-engine endpoints Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants