-
-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add bongcloud variations [WIP - Need to fix lint checks] #144
base: master
Are you sure you want to change the base?
Add bongcloud variations [WIP - Need to fix lint checks] #144
Conversation
I will fix it so lint check will pass |
order alphabetically as intended to fix lint error
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the openings need to be in ECO and then alphabetical order
SwiftyProgrammer690#1
My bad, |
It's all good... I just merged the most recent version, I'm going to check if Lil Bongcloud Attack still needs to be on line 207, after King's Pawn Opening: Van Hooydoon Gambit |
Hits from the bong! If you do it like this it will pass the checks. diff --git a/a.tsv b/a.tsv
index 1a46c90..f419599 100644
--- a/a.tsv
+++ b/a.tsv
@@ -10,6 +10,7 @@ A00 Barnes Opening: Fool's Mate 1. f3 e5 2. g4 Qh4#
A00 Barnes Opening: Gedult Gambit 1. f3 d5 2. e4 g6 3. d4 dxe4 4. c3
A00 Barnes Opening: Gedult Gambit 1. f3 f5 2. e4 fxe4 3. Nc3
A00 Barnes Opening: Hammerschlag 1. f3 e5 2. Kf2
+A00 Bongcloud Attack: Lil Bongcloud 1. e3 e5 2. Ke2
A00 Clemenz Opening 1. h3
A00 Clemenz Opening: Spike Lee Gambit 1. h3 h5 2. g4
A00 Creepy Crawly Formation: Classical Defense 1. h3 d5 2. a3 e5
diff --git a/c.tsv b/c.tsv
index d3af7f8..ecea383 100644
--- a/c.tsv
+++ b/c.tsv
@@ -183,6 +183,7 @@ C19 French Defense: Winawer Variation, Poisoned Pawn Variation, Paoli Variation
C19 French Defense: Winawer Variation, Positional Variation 1. e4 e6 2. d4 d5 3. Nc3 Bb4 4. e5 c5 5. a3 Bxc3+ 6. bxc3 Ne7 7. Nf3
C20 Barnes Opening: Walkerling 1. f3 e5 2. e4 Nf6 3. Bc4
C20 Bongcloud Attack 1. e4 e5 2. Ke2
+C20 Bongcloud Attack: Double Bongcloud 1. e4 e5 2. Ke2 Ke7
C20 Center Game 1. e4 e5 2. d4
C20 English Opening: The Whale 1. e4 e5 2. c4
C20 King's Pawn Game 1. e4 e5 Note that the ECO code for All things being equal, it would make sense to me to group two lines -- that is, to make them subvarations of a larger variation-"family" (or species of a genus) -- in accordance with the degree of their independence from all other lines. Namely, whether the typical positions they lead to are exhibiting distinct pawn structures, hence different ideas, tactical motifs, plans, what have you. "Systems" like the Bongcloud, arguably, are as independent as it gets. So maybe they should go into their own "family". Two bongs are after all, in form and function, more alike each other than they are like any other thing. That being said, what I wouldn't like to see is people gratuitously attaching names to arbitrary moves just because it's easy. A name should at least reflect (their country's) common usage. For example, I've never seen the name "Lil' Bongcloud" used anywhere, for anything, so I would lean towards leaving it out. Morover, ideally, the promotion of a random sequence of moves into a named and labeled "system" should probably, more than anything, aspire to honor the work of a theorist; someone who spent considerable time and effort in analyzing the positions resulting from said sequence, desiring to derive its truth in an attempt to demonstrate that either it is or is not viable to play. (And I would certainly accept the work and effort of a Cheech or Chong.) Anything less could be construed as disrespectful to the long, distinguished history of our game. In the absence of a ready theorist, it is true, we might make do with names of cities ("Cambridge Springs Defense"), countries ("Sicilian Defence ... Yugoslav Attack"), animals ("Hippopotamus Attack"), but lastly, and only as a last resort, might we stoop so low as to derive our grand and high mnemonics from such base and petty things as actual things ("Nescafe Frappe Attack")! So, all jokes aside, this is what I think you rather should be aiming for. Because "Double Bongcloud", at least, is indeed in demonstrably common usage. diff --git a/c.tsv b/c.tsv
index d3af7f8..ecea383 100644
--- a/c.tsv
+++ b/c.tsv
@@ -183,6 +183,7 @@ C19 French Defense: Winawer Variation, Poisoned Pawn Variation, Paoli Variation
C19 French Defense: Winawer Variation, Positional Variation 1. e4 e6 2. d4 d5 3. Nc3 Bb4 4. e5 c5 5. a3 Bxc3+ 6. bxc3 Ne7 7. Nf3
C20 Barnes Opening: Walkerling 1. f3 e5 2. e4 Nf6 3. Bc4
C20 Bongcloud Attack 1. e4 e5 2. Ke2
+C20 Bongcloud Attack: Double Bongcloud 1. e4 e5 2. Ke2 Ke7
C20 Center Game 1. e4 e5 2. d4
C20 English Opening: The Whale 1. e4 e5 2. c4
C20 King's Pawn Game 1. e4 e5 Cheers! |
I added some other bongcloud variations.
I was going to add the Hammerschlag Variation:
But there is an opening called the pork-chop opening (just a different name for the Hammerchlag) that is already registered on lichess. It's possible that we could change the name; But, that's debatable...