Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

display check *after* piece animation finishes #273

Open
sohamkorade opened this issue Jul 10, 2023 · 0 comments
Open

display check *after* piece animation finishes #273

sohamkorade opened this issue Jul 10, 2023 · 0 comments

Comments

@sohamkorade
Copy link

lichess

Currently, the animation behavior follows the pattern shown on the left. However, I suggest that the behavior depicted on the right would be more natural, particularly when navigating backward in a PGN game.

Left (current): Displays check as soon as the piece leaves its original square.
Right (proposed): Displays check after the piece reaches its destination square.

Code changes required:
Exclude the appending of a new square with the check class until the piece animation has finished.

Your feedback is greatly appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant