Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broadcasts: Do not enable pinned streaming on unsupported resolutions #16480

Open
SergioGlorias opened this issue Nov 26, 2024 · 7 comments
Open

Comments

@SergioGlorias
Copy link
Contributor

computers with old monitors (square format) and smartphones are punished by not being able to use advanced SF

@schlawg
Copy link
Collaborator

schlawg commented Nov 26, 2024

one approach is to have relayCtrl.ts re-request a new cross site isolated page when the layout is too small for video. this forces a cookie vs request parameter tradeoff. cookies will banish embeds until they expire (meaning resizing your window or switching to landscape won't recover it). whereas the request parameter approach will have better resize but ends up hitting the endpoint twice for every small screen.

to avoid that tradeoff, we'd need to change the default relay round endpoint to become a javascript assisted redirect because we need javascript/css to reliably check viewport width.

thibault may favor one of these vs another. i don't really have a feeling for it.

@ornicar
Copy link
Collaborator

ornicar commented Nov 27, 2024

On popular broadcasts, positions have cloud evals, so there is no need for any local analysis. Whether you get HCE or NNUE stockfish, your eval will be the same one coming from the server cache.

So... maybe it's not much of an issue at all?

@SergioGlorias
Copy link
Contributor Author

Not all broadcasts have the cloud, and if the user wants to analyze the movements placed by him, he does not have access to the sf

@schlawg
Copy link
Collaborator

schlawg commented Nov 27, 2024

pinned streamer is an unfortunate feature.

@schlawg
Copy link
Collaborator

schlawg commented Dec 1, 2024

anyone remember why we chose to launch people into the embed context when there's a pinned streamer? isn't a still image with a play button nag enough?

@ornicar
Copy link
Collaborator

ornicar commented Dec 2, 2024

You would need to ask the content team about that. I would also prefer loading an image rather than the bazillion twitch malwares.

@SergioGlorias
Copy link
Contributor Author

You would need to ask the content team about that. I would also prefer loading an image rather than the bazillion twitch malware.

what I remember was support for "non-lichess streamers", I don't remember being asked to remove the image

although I may have missed something

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants