-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Broadcasts: Do not enable pinned streaming on unsupported resolutions #16480
Comments
one approach is to have relayCtrl.ts re-request a new cross site isolated page when the layout is too small for video. this forces a cookie vs request parameter tradeoff. cookies will banish embeds until they expire (meaning resizing your window or switching to landscape won't recover it). whereas the request parameter approach will have better resize but ends up hitting the endpoint twice for every small screen. to avoid that tradeoff, we'd need to change the default relay round endpoint to become a javascript assisted redirect because we need javascript/css to reliably check viewport width. thibault may favor one of these vs another. i don't really have a feeling for it. |
On popular broadcasts, positions have cloud evals, so there is no need for any local analysis. Whether you get HCE or NNUE stockfish, your eval will be the same one coming from the server cache. So... maybe it's not much of an issue at all? |
Not all broadcasts have the cloud, and if the user wants to analyze the movements placed by him, he does not have access to the sf |
pinned streamer is an unfortunate feature. |
anyone remember why we chose to launch people into the embed context when there's a pinned streamer? isn't a still image with a play button nag enough? |
You would need to ask the content team about that. I would also prefer loading an image rather than the bazillion twitch malwares. |
what I remember was support for "non-lichess streamers", I don't remember being asked to remove the image although I may have missed something |
computers with old monitors (square format) and smartphones are punished by not being able to use advanced SF
The text was updated successfully, but these errors were encountered: