New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: creation of gif api #1250

Merged

veloce merged 1 commit into lichess-org:main from HaonRekcef:fix-gif

Dec 10, 2024

Contributor

HaonRekcef commented Dec 10, 2024

Fixes two bugs related to the GIF creation process:

Creating a GIF from studies while the current board theme was set to "system" did not work. It now defaults to brown.
Sometimes depending on the current theme, the board theme preferences were not respected due to a different naming in the GIF-API . This issue affected GIF creation for games (it defaulted to brown instead of the user prefs) and studies (GIFs were not created at all).

Also, I changed the labels of the board themes to include spaces, e.g., Blue2 → Blue 2.


          fix-gif-creation

c78f5dc

veloce approved these changes

View reviewed changes

Contributor

veloce left a comment

LGTM!

veloce merged commit 7978160 into lichess-org:main

1 check passed

HaonRekcef deleted the fix-gif branch

December 10, 2024 14:08

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet