Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Circular structure on error #58

Open
andyrichardson opened this issue Dec 7, 2020 · 2 comments · May be fixed by #59
Open

Circular structure on error #58

andyrichardson opened this issue Dec 7, 2020 · 2 comments · May be fixed by #59

Comments

@andyrichardson
Copy link

andyrichardson commented Dec 7, 2020

Hey there! First off, a huge thanks for authoring this, it's incredibly useful!

Unfortunately there is an issue with x-ray where data (errors, annotations, etc) cannot be properly serialized if they have a circular structure which leaves a potential for runtime crashes depending on the error.

Is it possible to get a release out of this which serializes the errors?

@andyrichardson andyrichardson linked a pull request Dec 7, 2020 that will close this issue
@mdlavin
Copy link
Member

mdlavin commented Dec 7, 2020

Thank you for using the library and providing a a pull request to make it better.

I haven't seen this type of circular error problem when sending errors to X-Ray, but I know that I have some errors with circular errors in our system. Do you know the source of the circular error?

@andyrichardson
Copy link
Author

Do you know the source of the circular error?

Sorry for the late response @mdlavin - I never got around to finding the source in the aws-xray source code. I know that we haven't seen it since adding this serialisation step

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants