Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite build-dependencies.sh in python/cmake #983

Open
mrexodia opened this issue Oct 27, 2022 · 3 comments
Open

Rewrite build-dependencies.sh in python/cmake #983

mrexodia opened this issue Oct 27, 2022 · 3 comments

Comments

@mrexodia
Copy link
Contributor

It looks like build-dependencies.sh currently only works on Linux (on macos 12 I get errors related to https://github.com/lifting-bits/cxx-common/blob/master/build_dependencies.sh#L95).

Would be nice if this script was rewritten in python or cmake so Windows can also be supported.

@ekilmer
Copy link
Collaborator

ekilmer commented Oct 27, 2022

Are the bash errors related to an old version of bash that comes pre-installed on macOS? (Check this issue #953)

Would be nice if this script was rewritten in python or cmake so Windows can also be supported.

Rewriting in Python3 (ideally version 3.7 minimum) would be nice. I'll consider it.

@mrexodia
Copy link
Contributor Author

mrexodia commented Oct 27, 2022

Yeah I guess that’s the problem. If you want I can send a PR with a fix, I just replaced-z with a different pattern.

perhaps changing from bash to “sh” would be better though (given zsh supports the script)

@ekilmer
Copy link
Collaborator

ekilmer commented Oct 27, 2022

A PR would be great! Thank you!

Edit: PR was made as #985

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants