We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
It looks like build-dependencies.sh currently only works on Linux (on macos 12 I get errors related to https://github.com/lifting-bits/cxx-common/blob/master/build_dependencies.sh#L95).
build-dependencies.sh
Would be nice if this script was rewritten in python or cmake so Windows can also be supported.
The text was updated successfully, but these errors were encountered:
Are the bash errors related to an old version of bash that comes pre-installed on macOS? (Check this issue #953)
Rewriting in Python3 (ideally version 3.7 minimum) would be nice. I'll consider it.
Sorry, something went wrong.
Yeah I guess that’s the problem. If you want I can send a PR with a fix, I just replaced-z with a different pattern.
perhaps changing from bash to “sh” would be better though (given zsh supports the script)
A PR would be great! Thank you!
Edit: PR was made as #985
No branches or pull requests
It looks like
build-dependencies.sh
currently only works on Linux (on macos 12 I get errors related to https://github.com/lifting-bits/cxx-common/blob/master/build_dependencies.sh#L95).Would be nice if this script was rewritten in python or cmake so Windows can also be supported.
The text was updated successfully, but these errors were encountered: