Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: adding an edge for file to symbol #60

Open
johnynek opened this issue Sep 1, 2018 · 3 comments
Open

feature: adding an edge for file to symbol #60

johnynek opened this issue Sep 1, 2018 · 3 comments

Comments

@johnynek
Copy link

johnynek commented Sep 1, 2018

Sculpt could be exactly what I need to break large scala targets into minimal dags for bazel to build.

The only thing missing is a mapping of which file each symbol is defined in, since bazel’s finest units (currently) are files.

How hard would it be to add this mapping? Something like [{ “file”: “Foo.scala”} , “produces”, {“sym”: [...

If you can coach me through this, I’m happy to send a PR if you thing this would be easy ish for someone unfamiliar with the compiler/plug-in.

@SethTisue
Copy link
Contributor

deja vu :-) https://contributors.scala-lang.org/t/sculpt-dependency-graph-extraction-for-scala/1507/3

yes, I think this is a modest, doable change, and if you get stuck, I'd be happy to help get you unstuck.

@johnynek
Copy link
Author

johnynek commented Sep 1, 2018

Thanks for the reminder. I’ll take a stab at this.

@SethTisue SethTisue changed the title Adding an edge for file to symbol feature: adding an edge for file to symbol May 16, 2019
@SethTisue
Copy link
Contributor

someone could pick up the old WIP PR at #61

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

2 participants