Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review ssl-config-akka scope #49

Open
jrudolph opened this issue Oct 13, 2016 · 0 comments
Open

Review ssl-config-akka scope #49

jrudolph opened this issue Oct 13, 2016 · 0 comments

Comments

@jrudolph
Copy link
Contributor

It seems there's still "common" functionality in ssl-config-akka:

  • everything related to SSLEngineConfigurator
  • validateDefaultTrustManager
  • configureProtocols
  • configureCipherSuites

These seem to be only in there because they want to log. It might make sense to either abstract logging or just use slf4j directly and then move / unify that with ssl-config.

Also, looseDisableSNI seems to operate both on client and server settings which doesn't make much sense (and the warning is probably inaccurate / wrong).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants