Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Routers are not a great example to build upon #11

Open
jugonzal opened this issue Nov 18, 2019 · 0 comments
Open

Routers are not a great example to build upon #11

jugonzal opened this issue Nov 18, 2019 · 0 comments

Comments

@jugonzal
Copy link

Students who use the skeleton are facing two basic problems while following this template:

  1. Because the router modules have only ONE route each, it is not obvious how to create a module that has multiple routes within. This would be easily fixable just by adding a second route to users.js for example.

  2. For some reason, since Knex was removed, we also lost the data abstraction layer. While there may not be a lot of need for it, putting everything in the router sets them for other challenges when doing this project as a team. Once team member may be working on routes and another on database queries, and with this architecture both of them would be working out of the same files, increasing the rate of conflicts.

These issues are only obvious since the skeleton was refactored for the new curriculum

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant