Merge pull request #3998 from erickcestari/encoded-offer-with-leading-whitespace

feat: add validation for leading whitespace in BOLT 12 bech32 strings

Author: TheBlueMatt

lightning/src/offers/parse.rs

@@ -43,7 +43,20 @@ mod sealed {
 			// Offer encoding may be split by '+' followed by optional whitespace.
 			let encoded = match s.split('+').skip(1).next() {
 				Some(_) => {
-					for chunk in s.split('+') {
+					let mut chunks = s.split('+');
+
+					// Check first chunk without trimming
+					if let Some(first_chunk) = chunks.next() {
+						if first_chunk.contains(char::is_whitespace) {
+							return Err(Bolt12ParseError::InvalidLeadingWhitespace);
+						}
+						if first_chunk.is_empty() {
+							return Err(Bolt12ParseError::InvalidContinuation);
+						}
+					}
+
+					// Check remaining chunks
+					for chunk in chunks {
 						let chunk = chunk.trim_start();
 						if chunk.is_empty() || chunk.contains(char::is_whitespace) {
 							return Err(Bolt12ParseError::InvalidContinuation);
@@ -123,6 +136,8 @@ pub enum Bolt12ParseError {
 	/// The bech32 encoding does not conform to the BOLT 12 requirements for continuing messages
 	/// across multiple parts (i.e., '+' followed by whitespace).
 	InvalidContinuation,
+	/// The bech32 string starts with whitespace, which violates BOLT 12 encoding requirements.
+	InvalidLeadingWhitespace,
 	/// The bech32 encoding's human-readable part does not match what was expected for the message
 	/// being parsed.
 	InvalidBech32Hrp,
@@ -322,6 +337,15 @@ mod tests {
 		}
 	}
 
+	#[test]
+	fn fails_parsing_bech32_encoded_offer_with_leading_whitespace() {
+		let encoded_offer = "\u{b}lno1pqpzwyq2p32x2um5ypmx2cm5dae8x93pqthvwfzadd7jejes8q9lhc4rvjxd022zv5l44g6qah+\u{b}\u{b}\u{b}\u{b}82ru5rdpnpj";
+		match encoded_offer.parse::<Offer>() {
+			Ok(_) => panic!("Valid offer: {}", encoded_offer),
+			Err(e) => assert_eq!(e, Bolt12ParseError::InvalidLeadingWhitespace),
+		}
+	}
+
 	#[test]
 	fn fails_parsing_bech32_encoded_offer_with_invalid_bech32_data() {
 		let encoded_offer = "lno1pqps7sjqpgtyzm3qv4uxzmtsd3jjqer9wd3hy6tsw35k7msjzfpy7nz5yqcnygrfdej82um5wf5k2uckyypwa3eyt44h6txtxquqh7lz5djge4afgfjn7k4rgrkuag0jsd5xvxo";