Replace Box::pin with core::pin::pin! where possible

.. as we can do that in a few places now.

Author: tnull

lightning-background-processor/src/lib.rs

@@ -668,7 +668,7 @@ use futures_util::{Joiner, OptionalSelector, Selector, SelectorOutput};
 #[cfg_attr(feature = "std", doc = "")]
 ///	let sleeper = move |d| {
 #[cfg_attr(feature = "std", doc = "		let mut receiver = stop_receiver.clone();")]
-///		Box::pin(async move {
+///		core::pin::pin!(async move {
 ///			tokio::select!{
 ///				_ = tokio::time::sleep(d) => false,
 #[cfg_attr(feature = "std", doc = "				_ = receiver.changed() => true,")]
@@ -769,7 +769,6 @@ where
 		let logger = &logger;
 		let kv_store = &kv_store;
 		let fetch_time = &fetch_time;
-		// We should be able to drop the Box once our MSRV is 1.68
 		Box::pin(async move {
 			if let Some(network_graph) = network_graph {
 				handle_network_graph_update(network_graph, &event)
@@ -923,7 +922,6 @@ where
 					)
 					.await
 			};
-			// TODO: Once our MSRV is 1.68 we should be able to drop the Box
 			let mut fut = Box::pin(fut);
 
 			// Because persisting the ChannelManager is important to avoid accidental
@@ -992,7 +990,6 @@ where
 					Ok(())
 				};
 
-				// TODO: Once our MSRV is 1.68 we should be able to drop the Box
 				futures.set_b(Box::pin(fut));
 
 				have_pruned = true;
@@ -1038,7 +1035,6 @@ where
 						Ok(())
 					};
 
-					// TODO: Once our MSRV is 1.68 we should be able to drop the Box
 					futures.set_c(Box::pin(fut));
 				}
 			},
@@ -1055,7 +1051,6 @@ where
 						Ok(())
 					};
 
-					// TODO: Once our MSRV is 1.68 we should be able to drop the Box
 					futures.set_d(Box::pin(fut));
 				}
 			},
@@ -2616,7 +2611,7 @@ mod tests {
 			Arc::clone(&nodes[0].logger),
 			Some(Arc::clone(&nodes[0].scorer)),
 			move |dur: Duration| {
-				Box::pin(async move {
+				core::pin::pin!(async move {
 					tokio::time::sleep(dur).await;
 					false // Never exit
 				})
@@ -3126,7 +3121,7 @@ mod tests {
 			Some(Arc::clone(&nodes[0].scorer)),
 			move |dur: Duration| {
 				let mut exit_receiver = exit_receiver.clone();
-				Box::pin(async move {
+				core::pin::pin!(async move {
 					tokio::select! {
 						_ = tokio::time::sleep(dur) => false,
 						_ = exit_receiver.changed() => true,
@@ -3341,7 +3336,7 @@ mod tests {
 			Some(Arc::clone(&nodes[0].scorer)),
 			move |dur: Duration| {
 				let mut exit_receiver = exit_receiver.clone();
-				Box::pin(async move {
+				core::pin::pin!(async move {
 					tokio::select! {
 						_ = tokio::time::sleep(dur) => false,
 						_ = exit_receiver.changed() => true,